Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 9, 2025

Adds the CDK to the package_deps of the @angular/aria package so that they're installed from source.

Adds the CDK to the `package_deps` of the `@angular/aria` package so that they're installed from source.
@crisbeto crisbeto requested a review from devversion October 9, 2025 11:01
@crisbeto crisbeto requested a review from a team as a code owner October 9, 2025 11:01
@crisbeto crisbeto requested review from ok7sai and tjshiu and removed request for a team October 9, 2025 11:01
@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Oct 9, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 9, 2025
package_name = "@angular/aria",
srcs = ["package.json"],
package_deps = [
":node_modules/@angular/cdk",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this fix? It makes sense to have, but just curious

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My assumption was that it might resolve the node_modules issue I had during the release yesterday.

@crisbeto crisbeto removed request for ok7sai and tjshiu October 9, 2025 11:49
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 9, 2025
@crisbeto crisbeto merged commit 0f7ae29 into angular:main Oct 9, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants